Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawing): set drawing bounding in left/top to A1 cell #4096

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix(drawing): set drawing bounding in left/top to A1 cell #4096

merged 2 commits into from
Nov 19, 2024

Conversation

VicKun4937
Copy link
Contributor

  • adjust drawing bounds in sheet viewport

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 40 seconds
commit  f8ab616
info  For more information, see full report

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (9630498) to head (f8ab616).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/scene.transformer.ts 0.00% 3 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 2 Missing ⚠️
...ne-render/src/components/sheets/sheet-component.ts 0.00% 1 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #4096      +/-   ##
==========================================
- Coverage   33.04%   33.04%   -0.01%     
==========================================
  Files        2437     2437              
  Lines      126822   126829       +7     
  Branches    28395    28395              
==========================================
- Hits        41912    41910       -2     
- Misses      84910    84919       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@lumixraku lumixraku merged commit e695309 into dev Nov 19, 2024
9 checks passed
@lumixraku lumixraku deleted the fix-drawing-bound branch November 19, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumixraku lumixraku lumixraku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VicKun4937 @lumixraku